Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fix gateway ut error #560

Merged
merged 1 commit into from
Mar 21, 2023
Merged

feat: fix gateway ut error #560

merged 1 commit into from
Mar 21, 2023

Conversation

xdlbdy
Copy link
Contributor

@xdlbdy xdlbdy commented Mar 21, 2023

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

@xdlbdy xdlbdy requested a review from hwjiangkai as a code owner March 21, 2023 02:42
@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Merging #560 (9a01f04) into main (ee76217) will decrease coverage by 1.17%.
The diff coverage is 49.01%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #560      +/-   ##
==========================================
- Coverage   57.07%   55.90%   -1.17%     
==========================================
  Files         190      191       +1     
  Lines       15191    15571     +380     
==========================================
+ Hits         8670     8705      +35     
- Misses       5884     6216     +332     
- Partials      637      650      +13
Impacted Files Coverage Δ
internal/controller/eventbus/block/block.go 35.93% <0.00%> (-16.70%) ⬇️
internal/controller/eventbus/block/selector.go 91.66% <ø> (-8.34%) ⬇️
internal/controller/trigger/storage/storage.go 0.00% <ø> (ø)
internal/controller/trigger/worker/policy.go 100.00% <ø> (ø)
internal/gateway/proxy/deadletter.go 0.00% <0.00%> (ø)
internal/primitive/cel/cel.go 68.57% <0.00%> (ø)
...rnal/primitive/interceptor/errinterceptor/error.go 0.00% <0.00%> (ø)
.../primitive/interceptor/memberinterceptor/member.go 0.00% <0.00%> (ø)
internal/primitive/queue/queue.go 87.87% <ø> (ø)
internal/primitive/transform/action/action.go 11.94% <ø> (ø)
... and 70 more

... and 39 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f7b4f7...9a01f04. Read the comment docs.

@xdlbdy xdlbdy merged commit 1a1328f into vanus-labs:main Mar 21, 2023
wenfengwang pushed a commit that referenced this pull request Mar 23, 2023
@xdlbdy
feat: fix gateway ut error (#560)
96f4694 
Signed-off-by: xdlbdy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwjiangkai hwjiangkai hwjiangkai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xdlbdy @hwjiangkai